Don't add planned tasks for legacy DAG runs #23007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically we could still infer planned runs even from a legacy DAG run (i.e. run without an explicit data interval), but that's probably not worth it. This will "fix" itself after that DAG is run one time against 2.2 anyway.
ashb
approved these changes
Apr 14, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
bbovenzi
approved these changes
Apr 14, 2022
|
cc @malthe |
|
Seems the referenced PR is not correct @uranusjr or am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in #22941 that when a DAG is last run before upgrading to Airflow 2.2, the calendar view would fail with an error because that last run does not contain data interval information.
This fixes the issue by simply not showing planned runs if the last run was made with data interval information. Technically we could still infer planned runs in this situation, but since it only affects the DAG temporarily and will "fix" itself after that DAG is run one time against 2.2 anyway, that's probably not worth it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.